-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] Migrate hr_employee_phone_extension #112
Conversation
Please move the view to views/hr_employee.xml and the hr.py to models/hr_employee.py. |
@charbeljc LGTM 👍 Don't forget to add yourself as contributor. |
@@ -23,7 +23,7 @@ | |||
from openerp.osv import fields, orm | |||
|
|||
|
|||
class hr_employee(orm.Model): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you migrate to new the API? This is a trivial module, so I don't think it is too much to ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @StefanRijnhart, done.
Thanks! 👍 |
|
||
|
||
|
||
Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove these sections where there is no useful content to add
Some comments/suggestions on the README, but 👍 |
OCA conventions: add README.rst, fix import
@dreispt, README.rst cleaned up, PR rebased. |
* internal_number | ||
* short_number | ||
|
||
Bugs are tracked on `GitHub Issues <https://github.com/OCA/hr/issues>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove Bug tracker title?
update |
@@ -20,4 +20,4 @@ | |||
# | |||
############################################################################## | |||
|
|||
from . import hr | |||
from .models import hr_employee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, but I think it is better to set :
from . import models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes of course
a little remark but 👍 |
], | ||
'demo': [], | ||
'test': [], | ||
'installable': False, | ||
'installable': True, | ||
'auto_install': False, | ||
'images': [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
images key is deprecated
👍 |
[MIG] Migrate hr_employee_phone_extension
[BSSFL-214] Setup test admin password
No description provided.